Fix quic client on TestValidator, alternative #27046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CriesofCarrots
force-pushed
the
fix-single-bind-2
branch
from
e599f85 to
24605f0
Compare
pgarg66
reviewed
Aug 10, 2022
CriesofCarrots
force-pushed
the
fix-single-bind-2
branch
from
24605f0 to
b753da7
Compare
CriesofCarrots
added
v1.11
automerge
|
automerge label removed due to a CI failure |
mergify
bot
removed
the
automerge
mergify bot
pushed a commit
that referenced
this pull request
Aug 10, 2022
Add new method to enable custom offset (cherry picked from commit 45c0da8)
mergify bot
added a commit
that referenced
this pull request
Aug 10, 2022
Fix quic client on TestValidator, alternative (#27046) Add new method to enable custom offset (cherry picked from commit 45c0da8) Co-authored-by: Tyera Eulberg <[email protected]>
This was referenced Aug 14, 2022
This was referenced Aug 15, 2022
xiangzhu70
pushed a commit
to xiangzhu70/solana
that referenced
this pull request
Aug 17, 2022
Add new method to enable custom offset
lijunwangs
pushed a commit
to lijunwangs/solana
that referenced
this pull request
Sep 11, 2022
…7046) (solana-labs#27053) Fix quic client on TestValidator, alternative (solana-labs#27046) Add new method to enable custom offset (cherry picked from commit 45c0da8) Co-authored-by: Tyera Eulberg <[email protected]>
lijunwangs
pushed a commit
to lijunwangs/solana
that referenced
this pull request
Sep 13, 2022
…7046) (solana-labs#27053) Fix quic client on TestValidator, alternative (solana-labs#27046) Add new method to enable custom offset (cherry picked from commit 45c0da8) Co-authored-by: Tyera Eulberg <[email protected]>
lijunwangs
pushed a commit
to lijunwangs/solana
that referenced
this pull request
Sep 13, 2022
…7046) (solana-labs#27053) Fix quic client on TestValidator, alternative (solana-labs#27046) Add new method to enable custom offset (cherry picked from commit 45c0da8) Co-authored-by: Tyera Eulberg <[email protected]>
lijunwangs
pushed a commit
to lijunwangs/solana
that referenced
this pull request
Sep 13, 2022
…7046) (solana-labs#27053) Fix quic client on TestValidator, alternative (solana-labs#27046) Add new method to enable custom offset (cherry picked from commit 45c0da8) Co-authored-by: Tyera Eulberg <[email protected]>
lijunwangs
pushed a commit
that referenced
this pull request
Sep 14, 2022
Fix quic client on TestValidator, alternative (#27046) Add new method to enable custom offset (cherry picked from commit 45c0da8) Co-authored-by: Tyera Eulberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
TestValidator doesn't work with the quic client on by default (as in #26927, for example); namely, transaction send attempts time out. This is because the ContactInfo assignment for a TestValidator (in
Node::new_single_bind) uses different port logic than what the client expects (quic offsets are hard-coded in the client).Summary of Changes
This alternative to #27044 replaces
bind_two_consecutive_in_range()with a method that takes a custom offset. This should accomplish the same thing as #27044 forNode::new_single_bind(), but also be useful forNode::new_localhost(), which might be run by multiple local nodes at the same time.Closes #27044